IntrepidPursuits / objective-c-style-guide

MIT License
4 stars 0 forks source link

Feedback CB: Disagree with image asset catelog use #8

Closed cprime closed 9 years ago

cprime commented 9 years ago

“Image assets should be contained in the Images.xcassets file.” This has some big implications for localization and we should probably come up with a convention for images that need to be localized. The options are basically (1) don’t put them in an xcassets file or (2) localize the filename and use different filenames for each language/region. (I vote for the former.)

Benuuu commented 9 years ago

What are the implications for localization?

colinbrash commented 9 years ago

http://stackoverflow.com/questions/21310819/how-to-localize-the-images-in-images-xcassets

brightredchilli commented 9 years ago

There has to be a better way here. The purpose of a style guide is to have convention over configuration - here is where we might say that localized images need to have a prefix - and come up with a UIImage override that will replace imagename with imagename-en or imagename-jp, so on and so forth.

I think until we have some projects that use localization it is probably premature to come up with a style guide to handle that.

colinbrash commented 9 years ago

"Images should be contained in .xcassets file(s) unless there is a good reason not to."