Closed alexpersian closed 7 years ago
Thanks for the feedback @Benuuu. Not sure why this is failing on the jenkins build.
retest this please
retest this please
retest this please
@bobgilmore @cprime any further feedback on this PR before we look at merging it in?
5 Warnings | |
---|---|
:warning: | There was an error collecting metrics for your project. This generally occurs due to test failures. Make sure all your tests are passing, and re-run the build. |
:warning: | Array+UtilitiesTests.swift#L100 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L100: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead.
XCTAssert(testArray[ip_safe: 3] == 4)
|
:warning: | Array+UtilitiesTests.swift#L101 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L101: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead.
XCTAssert(testArray[ip_safe: 8] == 9)
|
:warning: | Array+UtilitiesTests.swift#L102 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L102: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead.
XCTAssertNil(testArray[ip_safe: -1])
|
:warning: | Array+UtilitiesTests.swift#L103 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L103: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead.
XCTAssertNil(testArray[ip_safe: 9])
|
1 Message | |
---|---|
:book: | Executed 160 tests, with 0 failures (0 unexpected) in 0.262 (0.324) seconds |
Generated by :no_entry_sign: Danger
This PR encompasses a group of additions are currently being used within projects. I think that they are viable outside of the scope of just a single project though, and so propose adding them into Swift Wisdom for others to use. Definitely open for discussion on whether others agree with the usefulness.