Closed alexpersian closed 7 years ago
@mayasaxena that's a solid option. I'll look into that
This means every project using those items will need to ignore this rule to avoid getting violations. Should we rethink the naming convention here, or rethink the naming convention rule in SwiftLint for all projects?
@tzm41 this rule would only apply to the definition (so here in swift-wisdom), not in other projects that are using these methods.
4 Warnings | |
---|---|
:warning: | Array+UtilitiesTests.swift#L100 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L100: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead.
XCTAssert(testArray[ip_safe: 3] == 4)
|
:warning: | Array+UtilitiesTests.swift#L101 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L101: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead.
XCTAssert(testArray[ip_safe: 8] == 9)
|
:warning: | Array+UtilitiesTests.swift#L102 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L102: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead.
XCTAssertNil(testArray[ip_safe: -1])
|
:warning: | Array+UtilitiesTests.swift#L103 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L103: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead.
XCTAssertNil(testArray[ip_safe: 9])
|
1 Message | |
---|---|
:book: | Executed 142 tests, with 0 failures (0 unexpected) in 0.190 (0.246) seconds |
Generated by :no_entry_sign: Danger
Addresses the violations outstanding after initial SwiftLint integration.
The vast majority (~140) of violations were from our common naming scheme of
ip_methodName
, and the only other naming violations were from uppercase method names such asAfter
,Repeat
, etc. For this reason I've disabled theidentifier_name
rule from this our lint file for this project.The violations left were from
force_cast
andforce_try
in two files. In these instances the failure path is not defined, and we do not want the program to continue if these checks would fail. For that reason I've selectively disabled the rules around these blocks.After this PR violations are at
15 minor, 0 serious in 55 files
.