IntrepidPursuits / swift-wisdom

A collection of additions to the Swift Standard Library created by Intrepid Pursuits developers
MIT License
39 stars 14 forks source link

Alex/swiftlint violation fixes #134

Closed alexpersian closed 7 years ago

alexpersian commented 7 years ago

Addresses the violations outstanding after initial SwiftLint integration.

After this PR violations are at 15 minor, 0 serious in 55 files.

alexpersian commented 7 years ago

@mayasaxena that's a solid option. I'll look into that

tzm41 commented 7 years ago

This means every project using those items will need to ignore this rule to avoid getting violations. Should we rethink the naming convention here, or rethink the naming convention rule in SwiftLint for all projects?

alexpersian commented 7 years ago

@tzm41 this rule would only apply to the definition (so here in swift-wisdom), not in other projects that are using these methods.

ghost commented 7 years ago
4 Warnings
:warning: Array+UtilitiesTests.swift#L100 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L100: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead.
XCTAssert(testArray[ip_safe: 3] == 4)
:warning: Array+UtilitiesTests.swift#L101 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L101: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead.
XCTAssert(testArray[ip_safe: 8] == 9)
:warning: Array+UtilitiesTests.swift#L102 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L102: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead.
XCTAssertNil(testArray[ip_safe: -1])
:warning: Array+UtilitiesTests.swift#L103 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L103: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead.
XCTAssertNil(testArray[ip_safe: 9])
1 Message
:book: Executed 142 tests, with 0 failures (0 unexpected) in 0.190 (0.246) seconds

Generated by :no_entry_sign: Danger