Closed tzm41 closed 6 years ago
Waiting on https://github.com/SlatherOrg/slather/pull/321 to allow code coverage report be generated from Xcode 9 build.
Looks like the slather fix got merged. I think this is ready 👍
Sure, if we are ready for Swift 4
Need to get more people to review and approve
Do we need to add info the README to show how to point to the last good 3.x-compatible branch? And create said branch?
@tzm41 Definitely need some more reviews and buy-in, agreed.
Good idea @bobgilmore, but doesn't need a new branch, we should just make it clear that 0.8.4
is the last swift 3 version.
@paulrolfe Derp, of course.
Not STRICTLY related to the PR, but worth thinking about - what tag are we planning on using for the Swift 4-compatible release? Not 0.8.5, right? Going to bump to 0.9 or something? Asking because I have a project that I'd like to lock to 3.x-compatible versions, and I'd like (I think) to use ~>
in the Podfile, not < 0.8.5
@bobgilmore I value and respect your feedback and approval.
However, pod spec lint
is failing, so I think we do need some changes... investigating now 😁
Our team is definitely very respectful. Thanks guys!
This PR is waiting on a stable 4.0 release of RxSwift. According to RxSwift discussions that would be mid-October.
Hmm this is RC.. Are we good to go?
identifier_name
rule of SwiftLint disabled, unless we eventually decide againstip_
prefixes.Integer+Extensions
,UnsignedInteger+Extensions
, andMathable
could be reconsidered.This PR is waiting on a stable 4.0 release of RxSwift. According to RxSwift discussions that would be mid-October.