IntrepidPursuits / swift-wisdom

A collection of additions to the Swift Standard Library created by Intrepid Pursuits developers
MIT License
39 stars 14 forks source link

Swift 4 conversion #139

Closed tzm41 closed 6 years ago

tzm41 commented 7 years ago

This PR is waiting on a stable 4.0 release of RxSwift. According to RxSwift discussions that would be mid-October.

tzm41 commented 7 years ago

Waiting on https://github.com/SlatherOrg/slather/pull/321 to allow code coverage report be generated from Xcode 9 build.

paulrolfe commented 6 years ago

Looks like the slather fix got merged. I think this is ready 👍

tzm41 commented 6 years ago

Sure, if we are ready for Swift 4

tzm41 commented 6 years ago

Need to get more people to review and approve

bobgilmore commented 6 years ago

Do we need to add info the README to show how to point to the last good 3.x-compatible branch? And create said branch?

paulrolfe commented 6 years ago

@tzm41 Definitely need some more reviews and buy-in, agreed.

Good idea @bobgilmore, but doesn't need a new branch, we should just make it clear that 0.8.4 is the last swift 3 version.

bobgilmore commented 6 years ago

@paulrolfe Derp, of course.

Not STRICTLY related to the PR, but worth thinking about - what tag are we planning on using for the Swift 4-compatible release? Not 0.8.5, right? Going to bump to 0.9 or something? Asking because I have a project that I'd like to lock to 3.x-compatible versions, and I'd like (I think) to use ~> in the Podfile, not < 0.8.5

paulrolfe commented 6 years ago

@bobgilmore I value and respect your feedback and approval.

However, pod spec lint is failing, so I think we do need some changes... investigating now 😁

tzm41 commented 6 years ago

Our team is definitely very respectful. Thanks guys!

tzm41 commented 6 years ago

This PR is waiting on a stable 4.0 release of RxSwift. According to RxSwift discussions that would be mid-October.

tzm41 commented 6 years ago

Hmm this is RC.. Are we good to go?

ghost commented 6 years ago
1 Message
:book: Executed 167 tests, with 0 failures (0 unexpected) in 0.556 (0.655) seconds

Generated by :no_entry_sign: Danger