search

IntrepidPursuits / swift-wisdom

A collection of additions to the Swift Standard Library created by Intrepid Pursuits developers
MIT License
39 stars 14 forks source link

Swift 3.2 conversion #140

Closed tzm41 closed 7 years ago

tzm41 commented 7 years ago

Convert to Swift 3.2 syntax

Benuuu commented 7 years ago

How do these changes this affect Swift < 3.2?

I don't think we have a release strategy defined for maintaining versions, but we should probably bump at least a minor number (we're still in pre-release) and have a branch for anything that needs to be merged in for Swift < 3.2. @tzm41 do you have a sense of what we would need to do for release rollout?

tzm41 commented 7 years ago

You could still compile it using Xcode 8 / Swift 3 settings I think, since this PR is built with Xcode 8 on Jenkins.

In terms of version bump I agree that it should be bumped for this change.

tzm41 commented 7 years ago

With the backward compatibility I don't feel there should be much trouble for maintenance. I do think min deploy version of master should be at least 9.0 now.

tzm41 commented 7 years ago

@Benuuu bumped spec

tzm41 commented 7 years ago

Thanks you LGTM too @chow-land