Updated Version Format

[paulrolfe]

Summary Making the Version type act more like semver.org recommends. While leaving some wiggle room for some common mistakes when it comes to versioning. The typical errors you might see which we would allow here are:

• Leading zeroes are allowed.
  • A common error that should not prevent initialization.
  • i.e. 1.2.04 should be permitted but translated to it's more correct format: 1.2.4
• Non-alphanumeric characters are allowed in the preRelease and metaData
  • Found this requirement to be too cumbersome, when they are just strings anyway.
• Version numbers beyond the patch are dropped (but still create a valid version)
  • For example 1.2.3.4 would still intialize, but it would become 1.2.3

See http://semver.org for reference.

Why this is needed With the old implementation the following issues arose:

• 1.2.3-beta+abcdef would have returned a nil version.
• You could not manipulate a version once created.

What other changes were made

• New ip_suffix(from: String) and ip_prefix(upTo: String) methods added
  • This helps in parsing versions from strings.
  • Tests included.
• Slightly updated Comparable rules, as Version has some quirks. Such as metaData should not factor into precedence (but preRelease should) and the fact that 4.0.0 > 4.0.0-beta2 > 4.0.0-beta

[tzm41]

Tested on Xcode 9 as well?

[paulrolfe]

@tzm41 No, this is an update using swift 3. Swift 4 conversion can happen later -- this particular change is needed in a swift 3 project.

[tzm41]

@paulrolfe We have already updated Swift Wisdom to support Swift 3.2 / Xcode 9: https://github.com/IntrepidPursuits/swift-wisdom/pull/140. And for example BMAP Swift 3.2 will be dependent on Swift Wisdom being Xcode 9 compatible. Just want to make sure that this PR doesn't break Xcode 9 compatibility.

[paulrolfe]

@tzm41 Ah, understood. Didn't realize we were in 3.2 already.

[paulrolfe]

@tzm41 Confirmed that it works in Xcode9. ✅

[tzm41]

@paulrolfe awesome! Thanks for checking!

[ghost]

	4 Warnings
:warning:	Array+UtilitiesTests.swift#L100 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L100: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead. XCTAssert(testArray[ip_safe: 3] == 4)
:warning:	Array+UtilitiesTests.swift#L101 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L101: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead. XCTAssert(testArray[ip_safe: 8] == 9)
:warning:	Array+UtilitiesTests.swift#L102 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L102: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead. XCTAssertNil(testArray[ip_safe: -1])
:warning:	Array+UtilitiesTests.swift#L103 - SwiftWisdomTests/StandardLibrary/Array/Array+UtilitiesTests.swift#L103: ‘subscript(ip_safe:)’ is deprecated: Use ip_safely instead. XCTAssertNil(testArray[ip_safe: 9])

	1 Message
:book:	Executed 167 tests, with 0 failures (0 unexpected) in 0.605 (0.688) seconds

Generated by :no_entry_sign: Danger