Closed jpmendel closed 6 years ago
Hey guys - what's the status of this PR? Any chance of getting it merged in soon?
I'll get to all these sometime early this afternoon and update accordingly.
Before merging, you should do a rebase (and push --force-with-lease) to get rid of some of the redundant file changes. For example, 0de540a
, 1e3b1b5
, and 83cb616
should probably(?) all be collapsed into a single commit.
I think we should update the Jenkinsfile to specify Xcode 10.
Ok, I'll make these changes, make sure it compiles, and then @bobgilmore whenever you are finished with your App-Extension-Safe subspec PR and have it merged, I'll merge this and update the pod.
I'm having problems re-creating the problems related to the Today Extension, so feel free to proceed without that change.
I'd still like to see a passing Jenkins job - can you run it through Jenkins again?
Oh, also, as I noted at https://github.com/IntrepidPursuits/swift-wisdom/pull/155#issuecomment-426357849 , can you also do some squashing to clean up the git history a bit? Or are you planning on merging the whole thing as a "Squash and Merge?"
Yeah, was meaning to do that rebasing onto your extension commits, but if we are good to go without it, I can run through that now.
Any last calls on this before merging and updating the pod?