search

IntrepidPursuits / swift-wisdom

A collection of additions to the Swift Standard Library created by Intrepid Pursuits developers
MIT License
39 stars 14 forks source link

Support for Swift 4.2 #155

Closed jpmendel closed 6 years ago

jpmendel commented 6 years ago
nivektric commented 6 years ago

Hey guys - what's the status of this PR? Any chance of getting it merged in soon?

jpmendel commented 6 years ago

I'll get to all these sometime early this afternoon and update accordingly.

bobgilmore commented 6 years ago

Before merging, you should do a rebase (and push --force-with-lease) to get rid of some of the redundant file changes. For example, 0de540a, 1e3b1b5, and 83cb616 should probably(?) all be collapsed into a single commit.

paulrolfe commented 6 years ago

I think we should update the Jenkinsfile to specify Xcode 10.

jpmendel commented 6 years ago

Ok, I'll make these changes, make sure it compiles, and then @bobgilmore whenever you are finished with your App-Extension-Safe subspec PR and have it merged, I'll merge this and update the pod.

bobgilmore commented 6 years ago

I'm having problems re-creating the problems related to the Today Extension, so feel free to proceed without that change.

I'd still like to see a passing Jenkins job - can you run it through Jenkins again?

bobgilmore commented 6 years ago

Oh, also, as I noted at https://github.com/IntrepidPursuits/swift-wisdom/pull/155#issuecomment-426357849 , can you also do some squashing to clean up the git history a bit? Or are you planning on merging the whole thing as a "Squash and Merge?"

jpmendel commented 6 years ago

Yeah, was meaning to do that rebasing onto your extension commits, but if we are good to go without it, I can run through that now.

jpmendel commented 6 years ago

Any last calls on this before merging and updating the pod?