IntrepidPursuits / swift-wisdom

A collection of additions to the Swift Standard Library created by Intrepid Pursuits developers
MIT License
39 stars 14 forks source link

SW – adding framework targets to `SwiftWisdom.xcodeproj` so that `IpS… #159

Open Steven-Wu-ConnectedLab opened 5 years ago

Steven-Wu-ConnectedLab commented 5 years ago

…wiftWisdomandRxIpSwiftWisdom` can be consumed via Carthage

DO NOTE MERGE YET

Changes

Dependent Work

This PR is dependent on https://github.com/IntrepidPursuits/uikit-wisdom/pull/18 . After Ip-UI-Kit-Wisdom is consumable via Carthage, the Cartfile on this repo will need to be updated to point to the IntrepidPursuits/uikit-wisdom instead.

Notes

Impact to Consumers

Impact to Contributors

Because CocoaPods touches the workspace & project file (Pods-project and build-phases), to allow consumption via Carthage, these had to be removed to avoid build errors. This means that contributors must contribute via Carthage going forward instead of Cocoapods. Notably,

Impact to Workflows

These changes will likely break custom build/business workflows, or custom CI setups. I don't have any visibility into these workflows, so any feedback is appreciated.

Steven-Wu-ConnectedLab commented 5 years ago

CI failed as expected?

paulrolfe commented 5 years ago

@Steven-Wu-ConnectedLab Hey! Nice to hear from you! This PR is not forgotten. We just need to get together and think about implications of using Carthage moving forward. We'll get back to you with some reviews/questions soon. Cheers.