Open Steven-Wu-ConnectedLab opened 5 years ago
CI failed as expected?
@Steven-Wu-ConnectedLab Hey! Nice to hear from you! This PR is not forgotten. We just need to get together and think about implications of using Carthage moving forward. We'll get back to you with some reviews/questions soon. Cheers.
…wiftWisdom
and
RxIpSwiftWisdom` can be consumed via CarthageDO NOTE MERGE YET
Changes
IpSwiftWisdom
andRxIpSwiftWisdom
.Cartfile
.Dependent Work
This PR is dependent on https://github.com/IntrepidPursuits/uikit-wisdom/pull/18 . After Ip-UI-Kit-Wisdom is consumable via Carthage, the
Cartfile
on this repo will need to be updated to point to theIntrepidPursuits/uikit-wisdom
instead.Notes
Podfile
seem to mainly deal with Swift 4.2 migration which look to be complete now in0.11.0
, so I did not make project or script changes to accommodate those custom build configurations.IpSwiftWisdom
andRxIpSwiftWisdom
to align with the repo name. May want to consider changing the podspec name to match since it means that folks who consume via Cocoapods are currently doingimport Intrepid
as opposed toimport IpSwiftWisdom
.Impact to Consumers
README
to include Carthage consumption instructions.Impact to Contributors
Because CocoaPods touches the workspace & project file (Pods-project and build-phases), to allow consumption via Carthage, these had to be removed to avoid build errors. This means that contributors must contribute via Carthage going forward instead of Cocoapods. Notably,
pod install
, one would docarthage bootstrap
.Podfile
, one would update theCartfile
instead.Impact to Workflows
These changes will likely break custom build/business workflows, or custom CI setups. I don't have any visibility into these workflows, so any feedback is appreciated.