Fix iterator issue for A6 processors - Githubissues

IntrepidPursuits / swift-wisdom

A collection of additions to the Swift Standard Library created by Intrepid Pursuits developers

MIT License

39 stars 14 forks source link

Fix iterator issue for A6 processors #166

Closed paulrolfe closed 5 years ago

paulrolfe commented 5 years ago

Apparently optional Data? can sometimes return an empty Data object on old 32 bit processors (iPhone 5, 5c, iPad 4). You can see for yourself if you run the unit tests in Xcode 10.2 on iPhone 5 simulator.
I don't know why and I don't exactly know how. But this seems to fix it.
It also reads a little better.
There may be other places where changes like this are needed as well, but I haven't seen them.

ipbuildserver commented 5 years ago

	2 Warnings
:warning:	ResultTests.swift#L15 - SwiftWisdomTests/CommonTypes/ResultTests.swift#L15: ‘IPResult’ is deprecated: use Swift.Result instead `private final let successfulResult = IPResult<Int>.success(1)`
:warning:	ResultTests.swift#L16 - SwiftWisdomTests/CommonTypes/ResultTests.swift#L16: ‘IPResult’ is deprecated: use Swift.Result instead `private final let failureResult = IPResult<Any>.failure(ResultError.error)`

	1 Message
:book:	Executed 174 tests, with 0 failures (0 unexpected) in 0.323 (0.378) seconds

Generated by :no_entry_sign: Danger

jpmendel commented 5 years ago

Is this going to be 0.13.1?

paulrolfe commented 5 years ago

I'll update to 0.13.2