search

IntrepidPursuits / swift-wisdom

A collection of additions to the Swift Standard Library created by Intrepid Pursuits developers
MIT License
39 stars 14 forks source link

Update .swiftlint.yml to latest Intrepid version and clean up resulting issues #167

Closed bobgilmore closed 5 years ago

bobgilmore commented 5 years ago

This updates our two-year-old .swiftlint.yml to the latest version in https://github.com/IntrepidPursuits/swift-style-guide/blob/master/.swiftlint.yml , and cleans up the resulting warnings and errors.

I've created this PR with each class of warning or error handled in a separate commit, for ease of review. When I merge, I plan to squash all of the code changes down into one commit.

bobgilmore commented 5 years ago

Pulled in incorrect .swiftlint.yml.

ipbuildserver commented 5 years ago
2 Warnings
:warning: ResultTests.swift#L15 - SwiftWisdomTests/CommonTypes/ResultTests.swift#L15: ‘IPResult’ is deprecated: use Swift.Result instead
private final let successfulResult = IPResult<Int>.success(1)
:warning: ResultTests.swift#L16 - SwiftWisdomTests/CommonTypes/ResultTests.swift#L16: ‘IPResult’ is deprecated: use Swift.Result instead
private final let failureResult = IPResult<Any>.failure(ResultError.error)
1 Message
:book: Executed 174 tests, with 0 failures (0 unexpected) in 0.323 (0.385) seconds

Generated by :no_entry_sign: Danger