Array.ip_passes: duplicate of allSatisfy in stdlib
Set.ip_passes: duplicate of allSatisfy in stdlib
Set.ip_filter: duplicate of filter in stdlib
Added TODO comments:
Array.ip_uniqueValues: Inefficient implementation
EDIT: updated implementation, now requires Element to be Hashable
String.ip_dropFirst: propose renaming to ip_removeFirst to be more consistent with Apple API naming conventions
EDIT: renamed. ip_dropFirst() has been marked unavailable.
UIColor.init(hex:): propose adding documentation or making failable init
EDIT: made into failable init
Updated implementation:
String.range(from:)
UIView.ip_fromNib
Didn't touch yet but would like to remove/deprecate:
Array.ip_generator mostly duplicates the functionality of makeIterator() and is only needed if we need a type eraser that returns AnyIterator instead of IndexingIterator<Element>
String.subscript(range: CountableRange<Int>) Can be removed if Xcode 9 is no longer supported (I'm guessing yes?)
String.ip_length is this really necessary? Do people like ip_length better than using count directly?
Summary
Initial audit of Swift-Wisdom to remove out-of-date code. This was a fairly conservative pruning of low-hanging fruit. Jira ticket: https://intrepid.jira.digital.accenture.com/browse/DPIOS-4
Removed:
IPResult
and testsMarked as unavailable:
Array.ip_passes
: duplicate ofallSatisfy
in stdlibSet.ip_passes
: duplicate ofallSatisfy
in stdlibSet.ip_filter
: duplicate offilter
in stdlibAdded
TODO
comments:Array.ip_uniqueValues
: Inefficient implementationElement
to beHashable
String.ip_dropFirst
: propose renaming toip_removeFirst
to be more consistent with Apple API naming conventionsip_dropFirst()
has been marked unavailable.UIColor.init(hex:)
: propose adding documentation or making failable initUpdated implementation:
String.range(from:)
UIView.ip_fromNib
Didn't touch yet but would like to remove/deprecate:
Array.ip_generator
mostly duplicates the functionality ofmakeIterator()
and is only needed if we need a type eraser that returnsAnyIterator
instead ofIndexingIterator<Element>
String.subscript(range: CountableRange<Int>)
Can be removed if Xcode 9 is no longer supported (I'm guessing yes?)String.ip_length
is this really necessary? Do people likeip_length
better than usingcount
directly?