search

IntrepidPursuits / swift-wisdom

A collection of additions to the Swift Standard Library created by Intrepid Pursuits developers
MIT License
39 stars 14 forks source link

Fix bug in ip_fromNib() #173

Closed Nathaniel-Cox-Intrepid closed 4 years ago

Nathaniel-Cox-Intrepid commented 4 years ago

This PR fixes the "fix" I made in the previous PR. My aim way to simplify the logic of the ip_fromNib function, which looked pretty ungainly. Here I take this one step further and completely do away with the optionality of this function. The optionality was a bit of a false-friend to begin with, as Bundle.loadNibNamed(:owner:options:) actually throws a runtime error if it can't find a nib instead of returning an empty array. I've tested this in a sample app, and I'm reasonable sure that it works with all, some or none of the optional parameters, at least for the testing I did.

ipbuildserver commented 4 years ago
1 Message
:book: Executed 168 tests, with 0 failures (0 unexpected) in 0.429 (0.481) seconds

Generated by :no_entry_sign: Danger