Update for Swift3 - Githubissues

IntrepidPursuits / swift-wisdom

A collection of additions to the Swift Standard Library created by Intrepid Pursuits developers

MIT License

39 stars 14 forks source link

Update for Swift3 #51

Closed paulrolfe closed 8 years ago

paulrolfe commented 8 years ago

Let's add to-do's here that we want to address in the swift 3 transition:

[ ] Update any changed syntax (obvious)
[ ] Should we use ip_ prefix anymore?

alexpersian commented 8 years ago

Was there a change in Swift 3 that fixes the need for the ip_ prefix?

paulrolfe commented 8 years ago

No, you never needed it for swift since everything is namespaced. We just never took advantage and I'm wondering if we should now.

EDIT: To clarify, it's just not needed on our own public functions, classes, structs, etc. Extensions should still use it.

alexpersian commented 8 years ago

The extension ambiguous naming was what I was concerned about. How do other, larger projects solve this issue? EDIT: After looking through the repo it seems like it's already limiting the ip_ prefix to extensions. There was only one instance I found in PercentAnimate.swift where pa_percentAnimate could be renamed to ip_percentAnimate.

brightredchilli commented 8 years ago

OK - looks like our decision here is, use ip_ for extensions(this makes me extremely sad), but make sure that we do not prefix with ip for the rest of our code. Thanks for bringing up the awesome discussion.

brightredchilli commented 8 years ago

Closing this guy since we have other issues to track swift 3 migration