IntrepidPursuits / swift-wisdom

A collection of additions to the Swift Standard Library created by Intrepid Pursuits developers
MIT License
39 stars 14 forks source link

Update Rx subspec to Swift 3 syntax #57

Closed Benuuu closed 8 years ago

brightredchilli commented 8 years ago

can you rebase against swift-3?

Benuuu commented 8 years ago

I didn't actually test to see if the test worked because Tests aren't yet building. (it should, i hope)

vinnyt commented 8 years ago

update to the latest rxswift and :shipit:

brightredchilli commented 8 years ago

I would vote to not remove the disposable but this shouldn't block the swift 3 module.

Benuuu commented 8 years ago

Talked with @vinnyt about this. We're going to favor dropping the DisposeKey return here. FYI @brightredchilli

brightredchilli commented 8 years ago

@Benuuu @vinnyt rebased onto swift-3, updated to beta2, ran tests, renamed OperatorTests to Rx+ExtensionsTest.