search

IntrepidPursuits / swift-wisdom

A collection of additions to the Swift Standard Library created by Intrepid Pursuits developers
MIT License
39 stars 14 forks source link

Update swift-wisdom to Swift 3 #77

Closed brightredchilli closed 8 years ago

brightredchilli commented 8 years ago

This PR encompasses all changes to make Swift Wisdom compatible with Swift 3. Thanks everyone who helped out! The goal of this PR is to get a workable swift wisdom so that people can start using it in their projects. Therefore, there remains some TODOs and some inconsistencies. This PR includes changes from nyc/standard-library, whose commits have been reviewed. This PR also includes two unreviewed commits:

This commits can be reviewed individually.

Other than that, all tests are passing, and I have tested this against a swift-3 project. :tada: To try it out, add this to your Podfile:

pod 'Intrepid', :git => 'https://github.com/IntrepidPursuits/swift-wisdom.git', :tag => '0.6.0'

Once I get 2 approvals, I will merge this into master. Like the real master. Really.

brightredchilli commented 8 years ago

actually, 4 unreviewed commits, the last 2 to update pods and add attributions are also technically unreviewed.

Benuuu commented 8 years ago

Looks like we didn't get dropping CompositeDisposable's key into this PR. I will add it