search

Intrepidd / working_hours

⏰ A modern ruby gem allowing to do time calculation with business / working hours.
https://github.com/Intrepidd/working_hours
MIT License
533 stars 30 forks source link

Example spec with fractional hours causing infinite loop #27

Closed watsonbox closed 8 years ago

Intrepidd commented 8 years ago

Thanks very appreciated. I or @jarthod will have a look soon On Wed, 2 Dec 2015 at 20:53, Howard Wilson notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/Intrepidd/working_hours/pull/27 Commit Summary

  • Example spec with fractional hours causing infinite loop

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Intrepidd/working_hours/pull/27.

watsonbox commented 8 years ago

No problem. Sorry I don't have time to look into this and provide a fix myself.

watsonbox commented 8 years ago

Well, I had time to come up with a solution but probably not the most elegant one :).

jarthod commented 8 years ago

This last fix is good @watsonbox, thanks !

Intrepidd commented 8 years ago

Thanks for taking care of it Adrien 👍 On Sun, 6 Dec 2015 at 16:21, Adrien Jarthon notifications@github.com wrote:

Merged #27 https://github.com/Intrepidd/working_hours/pull/27.

— Reply to this email directly or view it on GitHub https://github.com/Intrepidd/working_hours/pull/27#event-483744771.

jarthod commented 8 years ago

Released in 1.1.2.