search

IntrospectiveSystems / xGraph

Introspective Systems, developer of xGraph, collaborative AI platform for data systems
https://www.introspectivesystems.com/
GNU Affero General Public License v3.0
14 stars 3 forks source link

Check Entity file exists in Module zip, before trying to extract it #75

Open tjgionet opened 6 years ago

tjgionet commented 6 years ago

The error showed up as an async of null. Due to the loading of an unavailable file in jszip

valyrie97 commented 6 years ago

not sure what this means, is this checking that the "Entity" key inside of schemas need to match an actual file in the module?

valyrie97 commented 5 years ago

when we load the entity file from the zip, right now we do it blindly, with faith the schema is correct. if its not, we get an unhelpful error. this should instead throw an error, E_FILE_NOT_FOUND, and whoever uses the functionality, should use a try catch to recover from this correctly. should only be found within genEntity and genModule code.