Inumedia / SlackAPI

.NET Implementation of the Slack team communication platform API.
MIT License
452 stars 243 forks source link

Fixes timestamp serialization issue (#170) #171

Closed snechaev closed 5 years ago

snechaev commented 5 years ago

This should fix #170. The changes are:

Inumedia commented 5 years ago

Can you confirm that this works with .netcore?

snechaev commented 5 years ago

Yes, it should work on .netcore. According to MSDN, DateTime.ToString(String, IFormatProvider) and DateTime.ToString(IFormatProvider) overloads are available starting from .net core 1.0 as well as CultureInfo.InvariantCulture property (see https://docs.microsoft.com/en-us/dotnet/api/system.globalization.cultureinfo.invariantculture?view=netcore-1.0 and https://docs.microsoft.com/en-us/dotnet/api/system.datetime.tostring?view=netcore-1.0#System_DateTime_ToString_System_String_System_IFormatProvider_)

gpailler commented 5 years ago

The AppVeyor build is ok so it should work properly with .net core