Invadermonky / JustEnoughMagiculture

MIT License
1 stars 0 forks source link

Incompat with `I&F: RLCraft Edition` #19

Open Krutoy242 opened 2 weeks ago

Krutoy242 commented 2 weeks ago

Ice & Fire: RLCraft Edition is a maintained fork of IceAndFire that adds new features and backport ones implemented in newer MC versions.

I tried to install it on my E2EE modpack and game crashed several times, until I disabled all JEM config options in I&F section. Crash report:

net.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from Just Enough Magiculture (justenoughmagiculture)
Caused by: java.lang.NoClassDefFoundError: com/github/alexthe666/iceandfire/item/IafItemRegistry
    at com.invadermonky.justenoughmagiculture.util.modhelpers.IaFLootHelper$CustomLootDrop.applyIceAndFireFunctions(IaFLootHelper.java:106)
    at com.invadermonky.justenoughmagiculture.util.modhelpers.IaFLootHelper$CustomLootDrop.addLootFunction(IaFLootHelper.java:99)
    at com.invadermonky.justenoughmagiculture.util.modhelpers.IaFLootHelper$CustomLootDrop.lambda$addLootFunctions$0(IaFLootHelper.java:95)
    at java.util.Arrays$ArrayList.forEach(Arrays.java:4266)
    at com.invadermonky.justenoughmagiculture.util.modhelpers.IaFLootHelper$CustomLootDrop.addLootFunctions(IaFLootHelper.java:95)
    at com.invadermonky.justenoughmagiculture.util.modhelpers.IaFLootHelper$CustomLootDrop.addLootFunctions(IaFLootHelper.java:91)
    at com.invadermonky.justenoughmagiculture.util.modhelpers.IaFLootHelper$CustomLootDrop.<init>(IaFLootHelper.java:82)
    at com.invadermonky.justenoughmagiculture.util.modhelpers.IaFLootHelper$CustomLootDrop.<init>(IaFLootHelper.java:86)
    at com.invadermonky.justenoughmagiculture.util.modhelpers.IaFLootHelper.lambda$null$3(IaFLootHelper.java:35)
    at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)

crash-2024-11-02_10.48.45-client.txt crash-2024-11-02_10.38.15-client.txt

I know its not fail of JEM, since its like RLCraft rewritten lot of classes.

Invadermonky commented 2 weeks ago

I&F: RLCraft Edition is honestly a mess. It's less of a fork and more of a completely new mod. The author changed the location of a huge number of classes effectively breaking compatibility with every Ice and Fire addon.

It is unlikely that I will add support for this fork as it would require rewriting nearly every handler JEM uses for Ice and Fire integration.

Krutoy242 commented 2 weeks ago

Its ok, I will not use this fork then.