InventivetalentDev / AnimatedFrames

Play GIFs in Minecraft
MIT License
189 stars 34 forks source link

Validate the files you download... #215

Open Wild1145 opened 3 years ago

Wild1145 commented 3 years ago

Is your feature request related to a problem? Please describe. Currently (As mentioned on my previous issue #214 ) You can download any file you want, even if it isn't an image. This results in me being able to download huge test files for example, which will never be rendered, and throw errors in the console.

Describe the solution you'd like As an absolute minimum the plugin should validate the file extension to make sure that it is a valid image / gif / video. Ideally more sophisticated validation would be used to ensure that it is an actual valid image / gif / video, but anything would be better than the current state...

Describe alternatives you've considered We're looking currently at maintaining our own fork for our server to maintain this functionality, which we'd like to avoid doing if it can be properly built into the original plugin.

Additional context I managed to download a 10GB Hetzner test file by telling this plugin it was an image, downloaded it, filled up space on the disk, and errored out constantly on the console...

stale[bot] commented 3 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Wild1145 commented 3 years ago

Still Relevant.

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: stale[bot] @.> Sent: Wednesday, July 21, 2021 2:51:08 AM To: InventivetalentDev/AnimatedFrames @.> Cc: Ryan Wild @.>; Author @.> Subject: Re: [InventivetalentDev/AnimatedFrames] Validate the files you download... (#215)

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/InventivetalentDev/AnimatedFrames/issues/215#issuecomment-883822843, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAWWFKMTG3E4IFXYT2MLY73TYYRYZANCNFSM4462LKAQ.

The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. If you are not the intended recipient of this message or their agent, or if this message has been addressed to you in error, please immediately alert the sender by reply email and then delete this message and any attachments. If you are not the intended recipient, you are hereby notified that any use, dissemination, copying, or storage of this message or its attachments is strictly prohibited. ATLAS Media Group Ltd. puts the security of the client at a high priority. Therefore, we have put efforts into ensuring that the message is error and virus-free. Unfortunately, full security of the email cannot be ensured as, despite our efforts, the data included in emails could be infected, intercepted, or corrupted. Therefore, the recipient should check the email for threats with proper software, as the sender does not accept liability for any damage inflicted by viewing the content of this email. The views and opinions included in this email belong to their author and do not necessarily mirror the views and opinions of the company. Our employees are obliged not to make any defamatory clauses, infringe, or authorize infringement of any legal right. Therefore, the company will not take any liability for such statements included in emails. In case of any damages or other liabilities arising, employees are fully responsible for the content of their emails Please do not print this email unless it is necessary. Every unprinted email helps the environment.

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Wild1145 commented 2 years ago

Still Relevant.

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Wild1145 commented 2 years ago

Still Relevant.