Open Wild1145 opened 3 years ago
stale[bot]
commented
3 years ago Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Wild1145
commented
3 years ago Still Relevant.
Get Outlook for Androidhttps://aka.ms/AAb9ysg
From: stale[bot] @.> Sent: Wednesday, July 21, 2021 2:51:05 AM To: InventivetalentDev/AnimatedFrames @.> Cc: Ryan Wild @.>; Author @.> Subject: Re: [InventivetalentDev/AnimatedFrames] Limit on number of tiles (#217)
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/InventivetalentDev/AnimatedFrames/issues/217#issuecomment-883822824, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAWWFKPGKPVPYSPTJQ2CGMLTYYRYTANCNFSM4462NTTA.
The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. If you are not the intended recipient of this message or their agent, or if this message has been addressed to you in error, please immediately alert the sender by reply email and then delete this message and any attachments. If you are not the intended recipient, you are hereby notified that any use, dissemination, copying, or storage of this message or its attachments is strictly prohibited. ATLAS Media Group Ltd. puts the security of the client at a high priority. Therefore, we have put efforts into ensuring that the message is error and virus-free. Unfortunately, full security of the email cannot be ensured as, despite our efforts, the data included in emails could be infected, intercepted, or corrupted. Therefore, the recipient should check the email for threats with proper software, as the sender does not accept liability for any damage inflicted by viewing the content of this email. The views and opinions included in this email belong to their author and do not necessarily mirror the views and opinions of the company. Our employees are obliged not to make any defamatory clauses, infringe, or authorize infringement of any legal right. Therefore, the company will not take any liability for such statements included in emails. In case of any damages or other liabilities arising, employees are fully responsible for the content of their emails Please do not print this email unless it is necessary. Every unprinted email helps the environment.
stale[bot]
commented
2 years ago Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Wild1145
commented
2 years ago Still Relevant.
stale[bot]
commented
2 years ago Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Wild1145
commented
2 years ago Still Relevant.
What steps will reproduce the problem?
We've identified bugs where if you try to set the tiles to be the world borders, it uses any memory the server has left. To make sure this doesn't happen and to make sure that we don't end up in a state where things are generally un-stable, we want to have a configurable limit.
What were you expecting to happen? What happened instead?
It to error out gracefully not take up all server memory and totally crash the server
What version of the plugin are you using? Type /version <Plugin Name>
4.13.0-SNAPSHOT (According to the spigot download anyway)
What Spigot version are you using? Type /version
Tested on multiple 1.16.5 Builds
What plugins are you using? Type /plugins
Various, but that's un-related to this bug...
Do you have an error log? Use pastebin.com. If you're not sure, upload your whole server log
Not to hand, easy enough to just re-produce...
Did your client crash? Upload errors in .minecraft/logs/latest.log as well
No
Additional information? (Are you using Bungeecord? Did it work in previous versions? etc.)
As you have to select the bottom left and top right tiles, We suggest a calculation to happen and work out the maximum number of tiles that might be affected and if that goes above the pre-configured number, fail fast and reject the request.