InventivetalentDev / AnimatedFrames

Play GIFs in Minecraft
MIT License
189 stars 34 forks source link

Creating Frame on Minecraft 1.12.2 throws NullPointerException on 4.13.3 (works on 4.11.5) #234

Closed KotoriK closed 2 years ago

KotoriK commented 2 years ago

What steps will reproduce the problem?

  1. /afc test https://cdn.jsdelivr.net/gh/YukiCat-Dev/yukicat.facepack/pic/emoji/$19.94.jpg
  2. selecting points
  3. wait for render

Version info

Plugin version: 4.13.3 Server version: git-Paper-1618 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)

Logs

[18:22:24 INFO]: Kotori_K issued server command: /framecreate n https://cdn.jsdelivr.net/gh/YukiCat-Dev/yukicat.facepack/pic/emoji/$19.94.jpg
[18:22:26 WARN]: Exception in thread "pool-14-thread-12" java.lang.NullPointerException
[18:22:26 WARN]:        at org.inventivetalent.animatedframes.boundingbox.BoundingBoxAPI.getBoundingBox(BoundingBoxAPI.java:111)
[18:22:26 WARN]:        at org.inventivetalent.animatedframes.boundingbox.BoundingBoxAPI.getAbsoluteBoundingBox(BoundingBoxAPI.java:164)
[18:22:26 WARN]:        at org.inventivetalent.frameutil.BaseFrameMapAbstract.<init>(BaseFrameMapAbstract.java:60)
[18:22:26 WARN]:        at org.inventivetalent.animatedframes.AnimatedFrame.<init>(AnimatedFrame.java:124)
[18:22:26 WARN]:        at org.inventivetalent.animatedframes.FrameManager.createFrame(FrameManager.java:108)
[18:22:26 WARN]:        at org.inventivetalent.animatedframes.Commands$1$1$1$2.run(Commands.java:183)
[18:22:26 WARN]:        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
[18:22:26 WARN]:        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
[18:22:26 WARN]:        at java.base/java.lang.Thread.run(Thread.java:829)

Additional Infomation

Confirmed will work on 4.11.5

InventivetalentDev commented 2 years ago

just stick with the older version. latest version is only tested on 1.17.

KotoriK commented 2 years ago

Will there be any backport for old Minecraft in future version? like performance boost, etc.

InventivetalentDev commented 2 years ago

probably not

KotoriK commented 2 years ago

That's reasonable Thanks for your time.