search

InventivetalentDev / MapManager

MIT License
54 stars 20 forks source link

Request for slight performance optimization #63

Closed stylextv closed 3 years ago

stylextv commented 4 years ago

https://github.com/InventivetalentDev/MapManager/blob/3b8bec1f18ea3dc04ec2725353c30e00198e9b6b/src/org/inventivetalent/mapmanager/MapManagerPlugin.java#L86

When searching through all the possible map ids, looking for vanilla maps, wouldn't it be faster to start at 'Options.FORCED_OFFSET' rather than 0, since when getting a new, free map id you start searching at that offset:

https://github.com/InventivetalentDev/MapManager/blob/3b8bec1f18ea3dc04ec2725353c30e00198e9b6b/src/org/inventivetalent/mapmanager/DefaultMapManager.java#L124

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.80. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

InventivetalentDev commented 4 years ago

Yeah, that would probably be a bit faster, but shouldn't make much of a difference since that's just run on startup. I also think I'd like to keep it starting at 0, just in case there happen to be any used up maps before the forced-offset.
Thanks for the suggestion though :)

stale[bot] commented 3 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.