search

InventivetalentDev / MapManager

MIT License
54 stars 20 forks source link

The showInFrame function don't work #89

Closed Caranouga closed 2 years ago

Caranouga commented 2 years ago

Describe the bug I got the plugin to work, but when I try to put an image in a frame, nothing happens

Expected behavior It should normaly put the image in the itemframe

Screenshots

Code: https://www.toptal.com/developers/hastebin/iqebaneriq.java Console: https://www.toptal.com/developers/hastebin/cudakoxeya.md Screen of my setup: https://prnt.sc/EK-dB5Upj-UY

Additional context I've tried to update MapManager so, i've these plugins in the plugin folder: https://prnt.sc/Je5XE6hYW7Wd and this pom.xml https://www.toptal.com/developers/hastebin/ahecuvawig.xml

stijnb1234 commented 2 years ago

Describe the bug I got the plugin to work, but when I try to put an image in a frame, nothing happens

Expected behavior It should normaly put the image in the itemframe

Screenshots

Code: https://www.toptal.com/developers/hastebin/iqebaneriq.java Console: https://www.toptal.com/developers/hastebin/cudakoxeya.md Screen of my setup: https://prnt.sc/EK-dB5Upj-UY

Additional context I've tried to update MapManager so, i've these plugins in the plugin folder: https://prnt.sc/Je5XE6hYW7Wd and this pom.xml https://www.toptal.com/developers/hastebin/ahecuvawig.xml

Is your image scaled to 128x128 pixels?

Caranouga commented 2 years ago

Yes, my image is 128x128 pixels

Caranouga commented 2 years ago

photo_btm_4 06 07 0 Here is the photo I want to put in the item frame

InventivetalentDev commented 2 years ago

when are you calling the #addPhoto method?
does the image show in hour hand?
also, maybe try putting a map item into the item frame and holding one in your hand

Caranouga commented 2 years ago

I call the addPhoto function when a minecart passes over a sign with traincarts.

I use this function ItemFrameManager.addPhoto(info.getLine(2) //btm, main, photonumber //123456, info.getLine(3) //3000 Used for something else than the picture);

When I hold a map in my hand, it doesn't matter, it's still a vanilla map, and the map in the itemframe is also a vanilla map

My new setup: https://prnt.sc/dgRy3L-3a0PM

UPDATE: When I hold a map in my hand, it doesn't matter, it's still a vanilla map, but when i create a new map this is not a vanilla map, but a map with my photo

Caranouga commented 2 years ago

I tried to put the code from my sign in an order, and it worked! I think there must be a problem with the traincarts and mapmanager signs!

Thanks to all !