search

InventivetalentDev / PacketListenerAPI

API to modify Minecraft packets
https://www.spigotmc.org/resources/2930/
MIT License
179 stars 33 forks source link

Add ViaVersion Support? #3

Closed ghost closed 8 years ago

ghost commented 8 years ago

Could you add support for the ViaVersion? (https://www.spigotmc.org/resources/viaversion.19254/)

Because when I come in 1.10, says: "Unsupported protocol version 210"

Please.

InventivetalentDev commented 8 years ago

That message is nothing sent by PacketListenerAPI. I have tried multiple plugins that depend on the API on servers with ViaVersion, and they worked without issues.

ghost commented 8 years ago

When the PacketListenerAPI + ViaVersion + ProtocolSupport, are together, the error happens.

However, you can review the support for the ProtocolSupport?

Version: 1.8 (v1_8_R3)

(just a note: when using the/skinclear command, (NickNamer) nick on tab, stay invisible.)

InventivetalentDev commented 8 years ago

As I said, PacketListenerAPI does not send that error. Please open an issue for ViaVersion/Protocol support, since it's probably caused by those.

NickNamer issue tracker

FormallyMyles commented 8 years ago

@Kurimatzu Could you try with just ProtocolSupport and see if the issue happens with PS + PacketListener?

Without ProtocolSupport, ViaVersion has full compatibility with this API. (Possibly providing your server startup log might give us more insight, but from the looks of things it causes ProtocolSupport to override Via)

This probably isn't easily fixable unfortunate due to how aggressive protocol support is with netty injection. (it's most likely not a bug with PacketListenerAPI)

ghost commented 8 years ago

The problem is the packetlistenerAPI Yes, because when I use the ProtocolSupport + ViaVersion, doesn't happen the error.

FormallyMyles commented 8 years ago

@Kurimatzu Have you tried with just ProtocolSupport + PacketListenerAPI?

ghost commented 8 years ago

Yes, the problem continues.