Inventory-Tweaks / inventory-tweaks

Client mod for Minecraft
http://inventory-tweaks.readthedocs.org/
Other
266 stars 106 forks source link

Valid inventory slots being ignored #462

Open tofof opened 7 years ago

tofof commented 7 years ago

Unpredictable sorting behavior in which valid inventory slots with rules are not used. See examples.

Minecraft Version: 1.10.2 Inventory Tweaks Version: 1.61-58-a1fd884

Items: (in order as they appear within utility category in tree) Torch x1 Flint & Steel x8 Jukebox Bed x5 Book & Quill Ender Eye x1 Gold Horse Armor Diamond Horse Armor

Arrangement prior to every test:

. 1 2 3 4 5 6 7 8 9
A f&s f&s f&s f&s DHA tor book juk Eye
B --- --- --- --- --- --- --- --- ---
C --- --- --- --- --- --- --- --- ---
D Bed Bed Bed Bed f&s f&s f&s f&s GHA

Results:

Targets tor f&s juk Bed book Eye GHA DHA ok? Unused
C9-B5 B5 B5..C9 C9 A1..A4 A5 A6 A7 A8 (none)
A9-C9 A8-C8 A7-C7 A6-C6 A6 A1..A4 B6..C6 C8..C9 A5 A7..A9 B1 B2 B3 B4 B5 B7..B9 C7
B C5-C9 C5 B7..C9 A1 A2..A5 A6 A7 A8 A9 B1..B5
D2-D3 A4 B6 C8 D5-D6 A7 B9 C2 D8-D9 A1 B3 C5 C5 A1, A2, B2, B3, B5, B6, B8, B9 A3 A4..A7 A8 A9 B1 B2 B6 C8 B9 C2 B3

Unused = slots that should have been utilized from the ruleset and were ignored in favor of overflow. All rules are of the form <target> utility, in the order given. e.g. the final row corresponds to

D2-D3 utility A4 utility B6 utility C8 utility D5-D6 utility A7 utility B9 utility C2 utility D8-D9 utility A1 utility B3 utility C5 utility

Kobata commented 7 years ago

This appears to be related to the issues with stability mentioned in #239, just with rules in general.

It also seems related to changes made in the past for infinite loop prevention.

Things probably work better if there aren't multiple rules using identical item categories.