search

Inversed-Tech / eyelid

Private iris matching
Apache License 2.0
0 stars 0 forks source link

Make it easy to review performance changes on each PR #46

Closed teor2345 closed 3 months ago

teor2345 commented 3 months ago

We want to make sure our code continues to perform well. But we could accidentally merge a PR that significantly reduces performance.

At the moment, we need to manually check the benchmark output against the main branch. Which is easy to forget, particularly in PRs that we assume aren't changing performance.

So we could either:

Hopefully there is a bot or GitHub action for this.

teor2345 commented 3 months ago

Here's a manual performance change check, anything like this would be great: https://github.com/Inversed-Tech/eyelid/pull/47#issuecomment-2062979915

teor2345 commented 3 months ago

It looks like this is what we want for PR comments: https://github.com/benchmark-action/github-action-benchmark#alert-comment-on-commit-page

Rust: https://github.com/benchmark-action/github-action-benchmark/blob/master/examples/rust/README.md

And for performance over time, we can add a graph later (#53).