Monitor benchmark changes on each PR - Githubissues

Inversed-Tech / eyelid

Private iris matching

Apache License 2.0

0 stars 0 forks source link

Monitor benchmark changes on each PR #57

Closed teor2345 closed 3 months ago

teor2345 commented 3 months ago

This workflow posts a benchmark change comment on every PR.

If the benchmark is worse by:

30% - the comment turns into a warning
50% - the workflow fails the PR's CI run

Close #46

Other Changes

This PR disables the unused cargo bench runner binary, to avoid spurious command-line option errors: https://bheisler.github.io/criterion.rs/book/faq.html#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options

API Documentation

This PR implements the minimal setup using GitHub cache: https://github.com/benchmark-action/github-action-benchmark#minimal-setup

Future Work

Later PRs can add charts using GitHub pages (#53): https://github.com/benchmark-action/github-action-benchmark#charts-on-github-pages-1

teor2345 commented 3 months ago

This PR will need to merge and be run on main before we see any PR comments.

teor2345 commented 3 months ago

I admin-merged this PR because it needs to run on the main branch before we can test it on PRs.