search

Inversed-Tech / eyelid

Private iris matching
Apache License 2.0
0 stars 0 forks source link

Try to fix benchmark cache updates and add debug logs #66

Closed teor2345 closed 2 months ago

teor2345 commented 2 months ago

The benchmark cache for main isn't being updated, so benchmark baselines are a few PRs behind.

This PR also adds debug logging to diagnose any issues.

teor2345 commented 2 months ago

This comment should show baselines for all older benchmarks: https://github.com/Inversed-Tech/eyelid/pull/65#pullrequestreview-2016317760

But it actually has 2 missing:

Screenshot 2024-04-23 at 16 26 05
teor2345 commented 2 months ago

Cache updates only happen on main, so I'm going to admin-merge this fix.

teor2345 commented 2 months ago

That worked, the new names are now in the baseline:

Screenshot 2024-04-23 at 16 32 59
teor2345 commented 2 months ago

But it's not in the updated benchmark comment yet: https://github.com/Inversed-Tech/eyelid/pull/65#pullrequestreview-2016317760

Maybe we need to open a new PR for that.