I think we might have accidentally skipped the cleanup PR we talked about?
So after this PR, let’s stop modifying poly.rs, and move the function code to a new inverse.rs module.
When someone is working on code to top-level modules, it makes it harder for everyone else to change code anywhere inside those modules. Because any exported functions or types from their PRs will conflict with the large number of import changes needed for that code.
But if they use a separate module, then its imports are contained within that file and won’t conflict with anything else. Only its exported functions and types need to be added to poly.rs
teor2345
commented
5 months ago
I think we might have accidentally skipped the cleanup PR we talked about? So after this PR, let’s stop modifying
poly.rs, and move the function code to a newinverse.rsmodule.When someone is working on code to top-level modules, it makes it harder for everyone else to change code anywhere inside those modules. Because any exported functions or types from their PRs will conflict with the large number of import changes needed for that code.
But if they use a separate module, then its imports are contained within that file and won’t conflict with anything else. Only its exported functions and types need to be added to
poly.rs_Originally posted by @teor2345 in https://github.com/Inversed-Tech/eyelid/pull/69#discussion_r1582430488_