search

Inversion-NL / Toon-Android

Toon Android app for rooted Toon devices
MIT License
2 stars 2 forks source link

App crashes while fetching data #35

Closed RoadXY closed 4 years ago

RoadXY commented 4 years ago

Describe the bug App crashes while fetching data

App version (please complete the following information):

Smartphone (please complete the following information):

Additional context or information

java.lang.RuntimeException: 
  at android.app.ActivityThread.performResumeActivity (ActivityThread.java:4451)
  at android.app.ActivityThread.handleResumeActivity (ActivityThread.java:4483)
  at android.app.servertransaction.ResumeActivityItem.execute (ResumeActivityItem.java:52)
  at android.app.servertransaction.TransactionExecutor.executeLifecycleState (TransactionExecutor.java:176)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:97)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2175)
  at android.os.Handler.dispatchMessage (Handler.java:107)
  at android.os.Looper.loop (Looper.java:237)
  at android.app.ActivityThread.main (ActivityThread.java:7857)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:493)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1076)
Caused by: java.lang.NumberFormatException: 
  at java.lang.Integer.parseInt (Integer.java:618)
  at java.lang.Integer.valueOf (Integer.java:801)
  at com.toonapps.toon.helper.AppSettings.getAddress (AppSettings.java:118)
  at com.toonapps.toon.helper.AppSettings.getUrl (AppSettings.java:129)
  at com.toonapps.toon.data.RestClient.getDataFromSharedPreferences (RestClient.java:31)
  at com.toonapps.toon.data.RestClient.<init> (RestClient.java:26)
  at com.toonapps.toon.controller.TemperatureController.<init> (TemperatureController.java:22)
  at com.toonapps.toon.controller.TemperatureController.getInstance (TemperatureController.java:28)
  at com.toonapps.toon.view.fragments.ControlsFragment.onResume (ControlsFragment.java:94)
  at androidx.fragment.app.Fragment.performResume (Fragment.java:2649)
  at androidx.fragment.app.FragmentManagerImpl.moveToState (FragmentManagerImpl.java:922)
  at androidx.fragment.app.FragmentManagerImpl.moveFragmentToExpectedState (FragmentManagerImpl.java:1238)
  at androidx.fragment.app.FragmentManagerImpl.moveToState (FragmentManagerImpl.java:1303)
  at androidx.fragment.app.FragmentManagerImpl.dispatchStateChange (FragmentManagerImpl.java:2659)
  at androidx.fragment.app.FragmentManagerImpl.dispatchResume (FragmentManagerImpl.java:2625)
  at androidx.fragment.app.Fragment.performResume (Fragment.java:2658)
  at androidx.fragment.app.FragmentManagerImpl.moveToState (FragmentManagerImpl.java:922)
  at androidx.fragment.app.FragmentManagerImpl.moveFragmentToExpectedState (FragmentManagerImpl.java:1238)
  at androidx.fragment.app.FragmentManagerImpl.moveToState (FragmentManagerImpl.java:1303)
  at androidx.fragment.app.FragmentManagerImpl.dispatchStateChange (FragmentManagerImpl.java:2659)
  at androidx.fragment.app.FragmentManagerImpl.dispatchResume (FragmentManagerImpl.java:2625)
  at androidx.fragment.app.FragmentController.dispatchResume (FragmentController.java:268)
  at androidx.fragment.app.FragmentActivity.onResumeFragments (FragmentActivity.java:479)
  at androidx.fragment.app.FragmentActivity.onPostResume (FragmentActivity.java:468)
  at androidx.appcompat.app.AppCompatActivity.onPostResume (AppCompatActivity.java:195)
  at android.app.Activity.performResume (Activity.java:8128)
  at android.app.ActivityThread.performResumeActivity (ActivityThread.java:4441)
RoadXY commented 4 years ago

Add extra check and/or try-catch for when the users has used strange/unlogical characters in the address field (and other)