Inversion-NL / nl.inversion.wunderground

Weather Underground app for Homey
2 stars 4 forks source link

Cannot save settings #30

Open goyaweb opened 7 years ago

goyaweb commented 7 years ago

After changing some values in the settings page (interval and notification setting) the save button at the bottom stays grayed out.

Inversion-NL commented 7 years ago

Is this still an issue?

goyaweb commented 7 years ago

yes

Inversion-NL commented 7 years ago

Could you provide steps so I can fully understand on how to reproduce the issue, please?

goyaweb commented 7 years ago

go to app settings for weather underground, change a setting and try to save with the button at the bottom next to test button using Chrome.

Inversion-NL commented 7 years ago

Did you get an error message?

goyaweb commented 7 years ago

Nope

On 21 August 2017 at 13:43:45, Inversion-NL (notifications@github.com) wrote:

Did you get an error message?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Inversion-NL/nl.inversion.wunderground/issues/30#issuecomment-323722743, or mute the thread https://github.com/notifications/unsubscribe-auth/AAv1b8FhJ_F7msptIPpFMbzaTd6u1-Unks5saW1vgaJpZM4MFb7S .

Inversion-NL commented 7 years ago

You did and test your settings before using the test button?

goyaweb commented 7 years ago

I did not use the test button

On 21 August 2017 at 13:45:41, Inversion-NL (notifications@github.com) wrote:

You did and test your settings before using the test button?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Inversion-NL/nl.inversion.wunderground/issues/30#issuecomment-323723098, or mute the thread https://github.com/notifications/unsubscribe-auth/AAv1b9Kp1R8PiY0uYQog5l6RJaYWnBB-ks5saW3lgaJpZM4MFb7S .

Inversion-NL commented 7 years ago

Could you try and let me know?

goyaweb commented 7 years ago

Test button works fine

On 21 August 2017 at 13:51:42, Inversion-NL (notifications@github.com) wrote:

Could you try and let me know?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Inversion-NL/nl.inversion.wunderground/issues/30#issuecomment-323724404, or mute the thread https://github.com/notifications/unsubscribe-auth/AAv1b20dMLaB5_Dx1C1j73TYhvxRpWjsks5saW9OgaJpZM4MFb7S .

Inversion-NL commented 7 years ago

If the test was okay without errors, you can save your settings. It's for preventing that the app won't work, or even crashes, when using the wrong settings

goyaweb commented 7 years ago

Well it’s not clear from the UI that you need to have a successful test first before being able to save some settings.

Hitting test gives me: this key is not valid due to exceeding rate plan.

But still I should be able to save the basic settings I think as non-pro features work just fine.

On 21 August 2017 at 14:01:33, Inversion-NL (notifications@github.com) wrote:

If the test was okay without errors, you can save your settings. It's for preventing that the app won't work, or even crashes, when using the wrong settings

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Inversion-NL/nl.inversion.wunderground/issues/30#issuecomment-323726295, or mute the thread https://github.com/notifications/unsubscribe-auth/AAv1b0Ghd5FZ9joaCDrG0I8POjQcueEgks5saXGagaJpZM4MFb7S .

Inversion-NL commented 6 years ago

You can get a free API key from their website which will allow you to up the frequency because the key I provide with the app hits the 500 requests a day within hours. I tried to limit the update frequency to 90min but even then I'm out of API calls quite fast

goyaweb commented 6 years ago

Still I think your UX is broken.

On 21 August 2017 at 17:20:13, Inversion-NL (notifications@github.com) wrote:

You can get a free API key from their website which will allow you to up the frequency because the key I provide with the app hits the 500 requests a day within hours. I tried to limit the update frequency to 90min but even then I'm out of API calls quite fast

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Inversion-NL/nl.inversion.wunderground/issues/30#issuecomment-323772614, or mute the thread https://github.com/notifications/unsubscribe-auth/AAv1b9K1WT11Pt0puO5ztL1NSn-gBDXYks5saaAngaJpZM4MFb7S .