search

Inversion-NL / nl.inversion.wunderground

Weather Underground app for Homey
2 stars 4 forks source link

Improved parsing abbreviations #33

Closed jghaanstra closed 7 years ago

jghaanstra commented 7 years ago

I noticed the parsing of the abbreviations only works for the built in voice triggers for app version 1.0.0. This pull request also parses it for the action cards. I also added some extra parsing mappings for people who use English speech.

Inversion-NL commented 7 years ago

Thanks!

Inversion-NL commented 7 years ago

Uploaded for approval to the store

jghaanstra commented 7 years ago

Wait, there is a bug in this pull request.

if (util.value_exist(forecastText)) Homey.manager('speech-output').say(parseAbbreviations(forecastText));

should be

if (util.value_exist(forecastText)) Homey.manager('speech-output').say(util.parseAbbreviations(forecastText));

Sorry about that!

Inversion-NL commented 7 years ago

NP, fixed it.

Inversion-NL commented 7 years ago

Published to the store