search

Invoca / style-guide

Centralized repository for all of Invoca's language style guides and HoundCI config
1 stars 2 forks source link

no_jira update to new rubocop names #54

Closed yinonrousso closed 4 years ago

alecjacobs5401 commented 4 years ago

I was just going to double check that. @yinonrousso what version of rubocop were you running with?

yinonrousso commented 4 years ago

I was running version (0.89.1.) Are we on an older version? @alecjacobs5401

alecjacobs5401 commented 4 years ago

@yinonrousso Yeah, you can see where web has it pinned to 0.74.0

If you were running into this while working in web, you can use bundle exec rubocop to ensure you use the correct version.

if you're running with it outside of web, we should pin those versions to match.

For what its worth, we have Hound to configure to run rubocop 0.72.0

yinonrousso commented 4 years ago

@alecjacobs5401 I was running it in pnapi_models. It was running at 0.76.0 before I ran a bundle update. I'll go ahead and lock it down in the Gemfile and close out this pr. Thank you!