search

Invoca / style-guide

Centralized repository for all of Invoca's language style guides and HoundCI config
1 stars 2 forks source link

no-jira: disable hyphenated_BEM css rule #63

Closed dep closed 3 years ago

dep commented 3 years ago

Our web repo has a lot of legacy code with dynamically generated snake_case classnames. Often times, during a simple code update, Hound will complain that these classes are not valid, causing us to either find/replace/refactor a large amount of code (which can be risky, or at the very least increase the scope of the case), or put ignore statements around the CSS rules.

Brought these concerns to the UI guild meeting and we decided it was fine to simply update the linter rules to remove hyphenated_BEM enforcement.

This Jira is to disable that rule.

dep commented 3 years ago

@lashkari

This will definitely clean up PR comments going forward! 🤫 🐕

For sure! Hopefully we can enforce our preferred class-name preference in future code reviews

dep commented 3 years ago

@lashkari Also quick question, what is the process lifecycle for the style-guide repo once a no-jira PR is approved?

lashkari commented 3 years ago

@lashkari Also quick question, what is the process lifecycle for the style-guide repo once a no-jira PR is approved?

To the best of my knowledge, this is all of the documentation we have on the subject.