InvoxiPlayGames / FestivalInstrumentMapper

Maps most existing Rock Band / Guitar Hero instruments as Xbox One instruments for Fortnite Festival.
http://festivalinstrumentmapper.com
GNU General Public License v2.0
139 stars 7 forks source link

Please add Whammy!! #108

Open ParasiteEve0 opened 2 months ago

Vultumast commented 2 months ago

Try my remapper PR https://github.com/Vultumast/FestivalInstrumentMapper/tree/main

ParasiteEve0 commented 2 months ago

Did not work for me Using GH PS3/RB PS3/RB Wii

Vultumast commented 2 months ago

Would you be willing to try a test version out for me and give me what it reads back?

ParasiteEve0 commented 2 months ago

Absolutely!

Vultumast commented 2 months ago

Whammy gip readtest.zip Would you try this and tell me if either number increases when you use your whammy bar?

ParasiteEve0 commented 2 months ago

It increases to 1 when activated on all three guitars, still does not work in game tho

Vultumast commented 2 months ago

The left or right value?

ParasiteEve0 commented 2 months ago

Left image

Vultumast commented 2 months ago

Do me a favor, try my latest PR release https://github.com/Vultumast/FestivalInstrumentMapper/releases/tag/4.0p3 After beginning your mapping follow these instructions 1) Click Adjust 2) On the popup dialog, click Add in the top left to add a new mapping profile 3) At the bottom of the form, you will ensure "Use Axis" is clicked for Tilt and Whammy groupboxes 4) Set Axis ID in the Tile groupbox to 0, and set the Whammy Axis ID to 1 Please be sure to update me if this fixes your issue! If not I will get to work right away on making a fix to ensure your whammy bar works in festival!

ParasiteEve0 commented 2 months ago

Well, The issue i'm having is where in game the controller goes crazy when i click start mapping

Vultumast commented 2 months ago

Does it go crazy in the preview in the release? Do you use this controller for steam? is HidHide properly configured?

ParasiteEve0 commented 2 months ago

Only in the PR release, Beta 3 works fine

Vultumast commented 2 months ago

Strange because I didn't touch the code relating to sending the information to fortnite or querying the information, can you elaborate on what you mean by "goes crazy" ?

ParasiteEve0 commented 2 months ago

I press strum bar once and it registers as multiple strum down inputs

Vultumast commented 2 months ago

Random hunch, try this one and see if it's any better. Beta 4 Preview 3.2 test.zip

ParasiteEve0 commented 2 months ago

https://github.com/InvoxiPlayGames/FestivalInstrumentMapper/assets/170736887/87ace66f-b70e-4823-99d3-b5f2da73a686

literally not pressing any button

Vultumast commented 2 months ago

Huh... Does the preview work correctly in the PR? Or does it only do this ingame

ParasiteEve0 commented 2 months ago

Only in game

Vultumast commented 2 months ago

Which specific controller are you using?

ParasiteEve0 commented 2 months ago

GH PS3/RB PS3/RB Wii

Trevor4521 commented 2 months ago

That is literally the exact same thing that happens to me using my xplorer guitar I just switched back to Emma's version which works perfectly fine

Vultumast commented 2 months ago

I have an Xplorer guitar, I will look into it and get back to you

Vultumast commented 2 months ago

Should be fixed now, try this https://github.com/Vultumast/FestivalInstrumentMapper/releases/tag/4.0p4

Trevor4521 commented 2 months ago

ok trying now

Trevor4521 commented 2 months ago

ok it working but no whammy yet image

Vultumast commented 2 months ago

Set Tilt Axis id to 0 and Whammy Axis ID to 1, save your profile and then try again (be sure to adjust the Tilt deadzone to 0!)

Trevor4521 commented 2 months ago

ok it working

Trevor4521 commented 2 months ago

Doesn't matter to me cause I usually use the button to activate overdrive but I can see some people wanting to tilt their guitar to activate overdrive, but that doesn't work now.I find it weird that Fortnite maps, overdrive activation and whammy to the same button

ParasiteEve0 commented 2 months ago

I have to hold down whammy to get it to work and overdrive also activates and sometimes the software closes by itself

Vultumast commented 2 months ago

Make a bug report on my repo then please!

fuximou commented 1 month ago

@Vultumast is your fork still available somewhere? the one linked in this issue seems to be removed. I also have an xplorer guitar and would love to use your fork so the boost and whammy is mapped properly.