search

Inwerpsel / use-theme-editor

A React theme editor
GNU General Public License v3.0
4 stars 0 forks source link

SVG class names not showing upon inspection #24

Closed Inwerpsel closed 1 year ago

Inwerpsel commented 1 year ago

While creating the code that extracts classes for an element, I made the apparently unreasonable assumption that this is just a string.

However, for SVGs it's a SVGAnimatedString, which is an object. I previously checked for its type as a quick fix.

Currently these classes are only used to format the label of the groups:

https://github.com/Inwerpsel/use-theme-editor/blob/2928d3d2cdd4619a073893ba3e8fe4bb3c7ee369/src/functions/groupVars.js#L9

The-Alan-Turing commented 1 year ago

Can you please guide me to the exact place in the code where we extract classes for an element?

Inwerpsel commented 1 year ago

Sure, I added it to the description.

Inwerpsel commented 1 year ago

I'm also interested to hear if there's any issues running and testing the code locally, as it wasn't tested on many different environments yet. Feel free to open an issue for anything you'd come across 🙏