Inwerpsel / use-theme-editor

A React theme editor
GNU General Public License v3.0
4 stars 0 forks source link

Finish implementation of custom props scoped to non-root selectors #29

Open Inwerpsel opened 1 year ago

Inwerpsel commented 1 year ago

Initially, this repo was only involved with custom properties set on the document root, and all functionality was built based on this assumption.

After finding it's very common to scope custom to non-root selectors (and also useful, better performance characteristics), support for this was added. However this support excluded some features in order to make the transition more manageable. This mostly concerns components that were in a very early state anyway.

From a UX POV, there's also a source of confusion. The selector may also be the reason why certain properties are on an element, but is only shown at the top level when a custom prop is set on that selector.