Inxmail / inx_magento1

Inxmail Professional Email Marketing für Magento CE und EE (1.x)
0 stars 0 forks source link

Offizielles Paket #7

Closed falco-knapp closed 9 years ago

falco-knapp commented 9 years ago

Hallo Janine,

das ZIP file konnte ich soweit installieren und testen. Da das Release aber eine etwas andere Datei-Struktur-Aufweist als vorher, müsste denke ich noch folgendes geklärt werden:

  1. Müssen für die Veröffentlichung auf Magento-Connect noch Anpassungen durchgeführt werden?
  2. Wird der Branch "stage" --> "master" gemerged und darauf dann ein veröffentlichbares Release gebaut?

Danke und lieben Gruß,

Falco

AlexanderPok commented 9 years ago

Hello Falco,

  1. It's necessary to do adoptions to release module on magento-connect(simply build it).
  2. Stage should be merge to master whenever release will be confirmed, and then package should be created from master branch I think.

What issues should be included in new release 3.1.0.5, both two closed ones from milestone 3.1.0.5?

Regards, Alexander

falco-knapp commented 9 years ago

Hi Alexander,

Milestone 3.1.0.5 is closed and confirmed in my eyes. I have tested the functionality and everything worked as far as I could evaluate it.

This is correct, 3.1.0.5 release should contain the issues of milestone 3.1.0.5.

So please proceed with the merge to master and create the final release 3.1.0.5 out of it.

Thanks,

Falco

falco-knapp commented 9 years ago

And please package the release in order for us to upload it to magento-connect

AlexanderPok commented 9 years ago

Hi Falco,

I merged everything to master branch along with package that can be uploaded to magento connect https://github.com/Inxmail/inx_magento1/blob/master/magento-connect/DndInxmail_Subscriber-3.1.0.5.tgz

Regards, Alexander

falco-knapp commented 9 years ago

Thank you Alexander!

I smoked-test the release and it worked so far. I was also able to upload the release to magento-connect.

One note: Is it normal to have the packaged module in the repository? I expected only to recieve the magento connect package file as a release file.

Doesn't that blow up the repository unnecessary?

AlexanderPok commented 9 years ago

Yes it can take some space from the repository, for the future we can just add updated "package.xml" file to the src folder and you will comress it by yourself, will it work?

falco-knapp commented 9 years ago

Hi Alexander,

I realised that we are missing the EE Version of the module. Could you please package it accordingly?

I would prefer to have a valid "tgz" file that can be uploaded to magento-connect as a delivery artefact instead of us having to create it. Would that be feasible?

Many thanks,

Falco

falco-knapp commented 9 years ago

Hallo Björn,

es fehlt leider noch die EE Version des Moduls. Könntet Ihr diese bitte noch nachreichen?

Vielen Dank und Gruß,

Falco

falco-knapp commented 9 years ago

Per Email erhalten.