search

Inzynierowie / Inzynierka

Our enineer work
3 stars 0 forks source link

Remove unnecessary tests. Fix additional blank test. Add @NotNull and @NotEmpty validiation for model. #30

Closed merkenter closed 4 years ago

merkenter commented 4 years ago

fix issue #29

merkenter commented 4 years ago

To check:

  1. mvn clean install should now start properly
  2. string model values should be rejected during POST method if nothing provided (500 error)
  3. long values should return 0 on default if nothing provided (200 OK)
  4. boolean values should return false on default if nothing provided(200 OK)
  5. Phone number should pass only values starts from 100000000 (to make sure that we don't have values like 999 etc.)
  6. DateTime values should be rejected during POST method if nothing provided (500 error)
Lukortech commented 4 years ago

Phone number value doesn't seem right. Remember that you can have eg. American phone numbers that are actually strings.

I don't think that kind of validation is doing us any good.