search

IoIxD / Cobblemounts

Cobblemon sidemod that lets you mount the Pokemon.
GNU Lesser General Public License v3.0
2 stars 11 forks source link

Fix GoalSelector crash #21

Closed Neovitalism closed 4 months ago

Neovitalism commented 8 months ago

Fixes crash caused by removing all goals - See crash report here.

Removing goals is redundant as Minecraft handles goals not being run while the entity has a passenger (Example: WanderAroundGoal#canStart())

I also changed it so the player must have an empty hand, as pokemon can hold more than just cobblemon items.

I also bumped version and changed the gradle from 48GB to 2GB because that absolutely demolished my 16GB RAM PC and is not needed lmao

Neovitalism commented 8 months ago

Could always just turn it into a config option, that change was requested of me when patching the crash

IoIxD commented 8 months ago

Feel free to turn it into a config option then, although given that whoever asked you was the first to ask in several months of this mod being out I think that the current option should be the default.

Neovitalism commented 8 months ago

Aye, shame on them for not asking for it directly then lol - had forked this before to make that exact change for someone months ago too

But ye, gotchu on default config option when I do get a minute

VOrlando520 commented 8 months ago

No one has asked because not many base users are aware of the repo or github in general and getting hold of you in your help channel in the cobblemon discord is near impossible lol

IoIxD commented 8 months ago

Fair enough. I stopped checking the channel after most of the discussion started becoming diplicate questions that others could answer. Sort of relied on people to ping me if they had new questions.