Fix broken code in proto2

truedat101 commented 6 years ago

Please keep build building, following errors:

source\accountcore.d(15,5): Error: empty attribute list is not allowed
source\accountcore.d(15,5): Error: use @(attributes) instead of [attributes]
source\accountcore.d(16,1): Error: declaration expected, not }
source\addresscore.d(61,5): Error: found unittest instead of statement
source\addresscore.d(66,1): Error: unrecognized declaration
source\blockcore.d(53,18): Error: basic type expected, not [
source\blockcore.d(53,28): Error: no identifier for declarator _error_[a - z][0 - 9]
source\blockcore.d(53,28): Error: found ) when expecting ;
source\blockcore.d(58,5): Error: found } when expecting )
source\blockcore.d(79,9): Error: found unittest instead of statement

truedat101 commented 6 years ago

I'd like to be able to walk through your progress tomorrow, so please make sure what you have can be built.

truedat101 commented 6 years ago

I fixed this for you last time, but I'd like for you to be building your own code.

pedroalvesbatista commented 6 years ago

I'm dealing with that right now, looking into integration of keypair with the account and address when starting the shell application, it's about 40 % done, but not properly working well yet

truedat101 commented 6 years ago

Ok, but can you fix the build.

truedat101 commented 6 years ago

@pedroalvesbatista most of these things to fix were super minor, very quick. Please look at the commits.

truedat101 commented 6 years ago

Something is crazy with keypair.d can't find the package.

truedat101 commented 6 years ago

Package missing prefix. Ooops.

truedat101 commented 6 years ago

@pedroalvesbatista Please in the future when you are checking in skeleton code, do the following:

Anything that is intended as concept code not meant to be compiled, just keep the code blocks commented out
Anything we don't really need anymore, remove it
Don't leave the build broken for more than a day. I know some people like to just type on the keyboard like it's a story, and let the story flow onto the screen, and then worry about does it build or is it correct. If the build is broken, you can't run tests, you can't even work on anything new
Focus on running code, not art, not perfection
favor testable code that compiles and fails over correct code that doesn't compile

pedroalvesbatista commented 6 years ago

Alright, finishing this bug issues for build.

truedat101 commented 6 years ago

@pedroalvesbatista can you fix the build:


source\blockcore.d(39,6): Error: function shelld.blockcore.genesisBlock has no return statement, but is expected to return a value of type uint
source\blockcore.d(47,30): Error: 'this' is only defined in non-static member functions, not newBlock
source\blockcore.d(47,8): Error: variable Hash is shadowing variable shelld.blockcore.newBlock.Hash
source\blockcore.d(48,30): Error: 'this' is only defined in non-static member functions, not newBlock
source\blockcore.d(48,8): Error: variable previousHash is shadowing variable shelld.blockcore.newBlock.previousHash
source\blockcore.d(49,30): Error: undefined identifier nonce, did you mean variable Nonce?
source\blockcore.d(49,8): Error: variable Nonce is shadowing variable shelld.blockcore.newBlock.Nonce
source\blockcore.d(50,30): Error: 'this' is only defined in non-static member functions, not newBlock
source\blockcore.d(50,8): Error: variable Timestamp is shadowing variable shelld.blockcore.newBlock.Timestamp
source\blockcore.d(51,30): Error: 'this' is only defined in non-static member functions, not newBlock
source\blockcore.d(57,15): Error: cannot implicitly convert expression blockStatus of type bool to string
source\blockcore.d(69,21): Error: function shelld.blockcore.newBlock (string Hash, string previousHash, string Nonce, string Timestamp) is not callable using argument types ()
source\blockcore.d(80,22): Error: function deimos.sodium.crypto_generichash.crypto_generichash (ubyte* out_, ulong outlen, const(ubyte)* in_, ulong inlen, const(ubyte)* key, ulong keylen) is not callable using argument types ()
source\blockcore.d(82,16): Error: cannot implicitly convert expression Hash of type ubyte to string
source\blockcore.d(94,9): Error: 'this' is only defined in non-static member functions, not validBlock
source\blockcore.d(122,24): Error: undefined identifier nonce, did you mean function Nonce? ldc2 failed with exit code 1.

DavidJ@blackstarface MINGW64 ~/dev/projects/TheShellProject.git/shell-d/prototype (proto2-dev)
$

pedroalvesbatista commented 6 years ago

Working on this now

pedroalvesbatista commented 6 years ago

'this' is only defined in non-static member functions, not validBlock this.Block.Timestamp = currentTimestamp;

IoTone / TheShellProject

Fix broken code in proto2 #38