search

IoTone / huenim

A nim-based set of language bindings for Philips HUE lighting. Clean room implementation.
MIT License
2 stars 0 forks source link

Fix tag issue in .nimble file #2

Open truedat101 opened 6 years ago

truedat101 commented 6 years ago

See https://github.com/nim-lang/packages/commit/e36fac6

ghost commented 6 years ago

@truedat101 I wanted to ask you: why are you using async http client? And why you have so much repeated code? You can write 1 proc to do API request, and then make other procs whose will cal this proc

ghost commented 6 years ago

@truedat101 you also can remove HUE prefix from consts and make them use PascalCase or camelCase. And you can have one "const" section

truedat101 commented 6 years ago

I'm a noob on the language. In terms of repeated code, are you referring to the test cases?

As far as using async http client, I guess this was just a choice based on the first example http code I saw for nim.

truedat101 commented 6 years ago

Happy to clean things up in the next revision.

ghost commented 6 years ago

@truedat101 no, not for test cases, but for source itself