search

IonBazan / composer-diff

Compares composer.lock changes and generates Markdown report so you can use it in PR description.
https://packagist.org/packages/ion-bazan/composer-diff
MIT License
143 stars 6 forks source link

Add Project Links #16

Closed giggsey closed 2 years ago

giggsey commented 2 years ago

Closes #15

giggsey commented 2 years ago

@IonBazan I haven't done the GitHub Formatter yet, as I'm unsure how it'll render urls.

For the markdown ones, I've put them as the package name rather than a new column

codecov[bot] commented 2 years ago

Codecov Report

Merging #16 (347c7ee) into main (52b0f49) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main       #16   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       176       197   +21     
===========================================
  Files             19        19           
  Lines            473       503   +30     
===========================================
+ Hits             473       503   +30
Impacted Files Coverage Δ
src/Formatter/AbstractFormatter.php 100.00% <100.00%> (ø)
src/Formatter/JsonFormatter.php 100.00% <100.00%> (ø)
src/Formatter/MarkdownListFormatter.php 100.00% <100.00%> (ø)
src/Formatter/MarkdownTableFormatter.php 100.00% <100.00%> (ø)
src/Url/BitBucketGenerator.php 100.00% <100.00%> (ø)
src/Url/GithubGenerator.php 100.00% <100.00%> (ø)
src/Url/GitlabGenerator.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 52b0f49...347c7ee. Read the comment docs.

IonBazan commented 2 years ago

Looks nice! Just need to add some more coverage and it will be good to go.

For the GitHub formatter, I think it would not look good with the links as they are not clickable so let's leave it as is.

IonBazan commented 2 years ago

Thanks @giggsey! Your changes were released as https://github.com/IonBazan/composer-diff/releases/tag/v1.6.0

giggsey commented 2 years ago

Thanks for the prompt reviews

image