search

IonBazan / composer-diff

Compares composer.lock changes and generates Markdown report so you can use it in PR description.
https://packagist.org/packages/ion-bazan/composer-diff
MIT License
143 stars 6 forks source link

Symfony 7 support #29

Closed IonBazan closed 9 months ago

IonBazan commented 9 months ago

As Symfony 7 adds return types to Commands which is a breaking change. To mitigate this, I did some hacks in order to maintain compatibility with both PHP 5.3 and older versions of Symfony by adding two base command variants and a conditional alias 🤮

Note: This only affects people using this library as a binary (vendor/bin/composer-diff) in a project where composer/composer and symfony/console are installed as dependencies. You can still use it as a Composer plugin (composer diff) with any version of Symfony without upgrading.

Doesn't look nice but works like a charm (see tests)

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7482e1f) 100.00% compared to head (005967f) 100.00%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #29 +/- ## =========================================== Coverage 100.00% 100.00% Complexity 206 206 =========================================== Files 19 19 Lines 596 610 +14 =========================================== + Hits 596 610 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.