search

IonicBrazil / ionic-garden

This project is for every ionite who wants to play with Ionic's Source
Other
14 stars 6 forks source link

Implement IIFE and named functions to accomplish the style guide #30

Closed giorgiofellipe closed 9 years ago

giorgiofellipe commented 9 years ago

This PR starts to implement the style guides mentioned on #23 #24 and a bit of #28 (https://github.com/IonicBrazil/ionic-garden/issues/28#issuecomment-115273985).

There should be some mistakes, so would be great if you take a depth look and help fix them.

felquis commented 9 years ago

@giorgiofellipe I'll push some commits to your branch while reviewing this pull request.

felquis commented 9 years ago

I forget to mention, I removed postinstall scripts, let's add it later when everything will be more stable

felquis commented 9 years ago

This workflow is going pretty well, I'll merge it because it's too big to stay working here.

felquis commented 9 years ago

I'll keep the issues open, cause we should close them with tests like JSCS, JSHint, if we can't ensure a style guide, we shouldn't close the corresponding style guide issue.

Thanks @giorgiofellipe sorry for that revert.