search

IonicaBizau / github-contributions

:octocat: A tool that generates a repository which being pushed into your GitHub account creates a nice contributions calendar.
MIT License
1.33k stars 116 forks source link

npm error on install: Couldn't read dependencies #19

Closed guilhermesad closed 10 years ago

guilhermesad commented 10 years ago

OS X Lion 10.7.4 Node v0.8.19

Console:

...
inflating: github-contributions-master/samples/I-love-Github.json
inflating: github-contributions-master/samples/happy-2014.json
inflating: github-contributions-master/server.js
mv: rename gh-contributions-master/* to ./*: No such file or directory
npm ERR! install Couldn't read dependencies
npm ERR! Error: ENOENT, open '/Users/guilherme/gh-contributions/package.json'
...
npm ERR! System Darwin 11.4.0
npm ERR! command "node" "/usr/local/bin/npm" "install"
npm ERR! cwd /Users/guilherme/gh-contributions
npm ERR! node -v v0.8.19
npm ERR! npm -v 1.1.71
npm ERR! path /Users/guilherme/gh-contributions/package.json
npm ERR! code ENOENT
npm ERR! errno 34
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /Users/guilherme/gh-contributions/npm-debug.log
npm ERR! not ok code 0
Sucessfully installed. Please type: cd ~/gh-contributions
Bye!

Not any additional info on npm-debug.log

IonicaBizau commented 10 years ago

It seems to be an issue in installer.sh script.

Try to clone the repository, install and start the app.

$ git@github.com:IonicaBizau/github-contributions.git
$ cd github-contributions
$ npm install
$ node server

Then open the localhost:9000 page in browser. Let me know if it works. The installer script need to be updated as well. :smile:

guilhermesad commented 10 years ago

I figured it out, it was indeed a problem in installer.sh. When downloading the repo archive the unzipped folder is called "github-contributions-master", not "gh-contributions-master". Accepting the pull request will close the issue

IonicaBizau commented 10 years ago

:+1:

Yes, I think that this happened because initially this repository was named gh-contributions. BTW, why don't you update Node?

I have v0.10.28 that seems to be the latest stable version (running Ubuntu 14.04).

guilhermesad commented 10 years ago

I'm not much of a Node user, so at the moment it doesn't make much difference. Still in my list of things to play though :)

IonicaBizau commented 10 years ago

I changed your commit message to be more relevant. :smile: Thank you!