improved #56

[aleen42]

• Here is a comtribution for killing the process of zipping generated repositories, and using child-process to run script to open local file instead.

[IonicaBizau]

@aleen42 Thank you for your contributions!

Can you please convert the tabs into spaces?

[aleen42]

Hello, @IonicaBizau, is there any problem about this pull request?

[IonicaBizau]

@aleen42 Hey! I'm just a little bit busy these days. I will take care of this PR soon!

[aleen42]

@IonicaBizau :facepunch: oh, thx

[IonicaBizau]

@aleen42 I will leave a couple of inline comments to make the merging easier for me. I'm a bit busy these days, but I'd also like to get this merged. Obviously, there's no rush, but delaying the things too much is also not a good thing. :hourglass:

[aleen42]

I have some opinions for using opn:

• The builder of opn has specified that it's safer to use spawn rather than exec. Nevertheless, I have done some research and found that spawn is so familiar with exec, and the only thing we should pay attention to is that exec will throw Error: maxBuffer exceeded when the stdout has exceeded the default buffer size - 200k. I think this project have no reason to worry about this.
• The second point is event if opn has done some test cases, our project will not use its functions of opening files, website or something else, which looks heavy.
• Finally, the only advantage of opn is its higher compatibility.

[IonicaBizau]

@aleen42 True. I'm going to test this now and merge it. :grin:

[IonicaBizau]

Ahhh, just realized we have a problem here: it will not be able to run in docker containers anymore because it opens the folder in UI, while when running as web app we need a zip file back.

[IonicaBizau]

@aleen42 :ship: 3.0.0 :tada: Thanks again! Regarding Docker, we will care about it when somebody will cry because of that.

[aleen42]

Orz, why my contribution is not counted in my profile? @IonicaBizau, do you mind figuring out my problem?

[IonicaBizau]

@aleen42 They are counted: https://github.com/aleen42?tab=contributions&from=2016-03-15

Some of them are not. For instance, this specific one is not counted because aleen42@vip.qq.cn is not added in your email settings.

:book: https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile/

[aleen42]

Orz, my email is aleen42@vip.qq.com rather than aleen42@vip.qq.cn.

[IonicaBizau]

But you did use it in your commits. You just have associate it with your GitHub account here.

[aleen42]

So, this project have not appeared in the right bottom list named Repositories contributed to, orz.

[IonicaBizau]

@aleen42 Because you have more activity in other repos, probably.

[aleen42]

@IonicaBizau Oh, I have forgotten it's ordered by the number of commits 😢