search

IonicaBizau / web-term

:tv: A fullscreen terminal in your browser.
MIT License
169 stars 21 forks source link

Prompt goes past bottom of screen #25

Closed scribe closed 8 years ago

scribe commented 8 years ago

Hello,

I'm not certain if this is a bug or a user error, but I couldn't find an issue like this.

When using recent versions of chrome the bottom lines of the terminal will always be slightly below the bottom of the window.

To reproduce: Start web-term then hit return until the prompt goes off the bottom of the screen in Chrome 46.

Thank you for your time.

IonicaBizau commented 8 years ago

Thanks for the report @scribe!

Can you tell me what font do you use? It is Monaco or something like that? I can reproduce it on my notebook where I use Monaco as monospace font, but not on my desktop (where monospace is used).

@lcristianiim Is it possible to compute the height of the terminal in the good way? :smile:

lcristianiim commented 8 years ago

I'll check it out

lcristianiim commented 8 years ago

@scribe I've failed to reproduce the bug you reported. I have tried it with Chrome 46.0.2490.71 and everything is nice and smooth. Please verify the font you are using as IonicaBizau suggested and let us know.

IonicaBizau commented 8 years ago

@lcristianiim Try to install the Monaco font. You will be able to reproduce it. We anyway need to debug this in jillix internal app. :smile:

IonicaBizau commented 8 years ago

:ship: 4.1.0 :tada:

scribe commented 8 years ago

@lcristianiim I was using Times, however the 4.1.0 patch has fixed the issue for me.

Thank you again for your help!

IonicaBizau commented 8 years ago

@scribe Awesome! Thanks for feedback! :smile:

lcristianiim commented 8 years ago

@scribe As @IonicaBizau said: Awesome! :+1: