search

IonicaBizau / web-term

:tv: A fullscreen terminal in your browser.
MIT License
168 stars 21 forks source link

Provide an option to acess web-term outside of localhost #30

Closed hmalphettes closed 8 years ago

hmalphettes commented 8 years ago

Thanks for this project! I was not able to access the web-interface outside of localhost without this change. Let me know if I missed something.

IonicaBizau commented 8 years ago

@hmalphettes This is great! :sparkles: Can you also add an example how to use this?

hmalphettes commented 8 years ago

Thanks @IonicaBizau. Sure, I am using it to access csysdig remotely running in a container: https://quay.io/repository/sutoiku/sysdig-web-term

So I am adding the example to the code. Note that with this suggested patch web-term is by default listening on "0.0.0.0". It is consistent with node's default behavior but different from the current behavior.

csysdig-remote-access
IonicaBizau commented 8 years ago

Thanks a lot! :sparkles:

IonicaBizau commented 8 years ago

@hmalphettes Improved in #31. :ship: 4.5.0 :tada:

hmalphettes commented 8 years ago

Many thanks @IonicaBizau. Many thanks for improving it so much and releasing it already.

IonicaBizau commented 8 years ago

@hmalphettes You're welcome! :+1: Thanks for contributing too! :smile: